Fix: Swap selection start and end index if selection is created from bottom to top #967
Conversation
Doodeletion
changed the title
Doodeletion
force-pushed
the
966-copying-from-file-diff-regression
branch
from
c27dc03 to
33c5da5
Compare
Doodeletion
force-pushed
the
966-copying-from-file-diff-regression
branch
from
33c5da5 to
b21bd52
Compare
|
Sorry for force-push chaos I committed with a wrong git config. Twice. :/ |
Actually, any exception in the UI thread or any uncaught exception in other threads can cause Avalonia to crash... The non-UI thread part has been handled, but for the UI thread, there is a considerable part that Avalonia itself has not handled (such as the rendering of AvaloniaEdit). For this specific case of copying a selection, it should not throw an exception. |
In my opinion, it is a good idea to wrap any code that is executed on the ui thread and not critical to the application (i.e. the application can "survive" the failure) in a try/catch, because bugs can always happen. When writing this code it initially had an indexing bug. Having the application crash when trying to copy text felt a bit extreme, when the copy buffer could simply have stayed empty. That being said, I don't think SourceGit ever crashed while I was using it. |
Fixes #966.
Copying from file diff view failed if the selection is created from bottom to top. This causes Selection.StartPosition to be below Selection.EndPosition, so the for loop would not run. Swapping start and end position in these cases fixes the issue.
On a different note, I noticed that any exception thrown in this event handler crashes the application. I think in some cases, such as this, it might be better to catch and log the exception and prompt the user about it.