Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The deletedBy column value should be configurable. #99

Closed
yeshamavani opened this issue Oct 31, 2022 · 1 comment · Fixed by #100
Closed

The deletedBy column value should be configurable. #99

yeshamavani opened this issue Oct 31, 2022 · 1 comment · Fixed by #100
Assignees
@RaghavaroraSF
Labels
released

Comments

@yeshamavani
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  1. Right now when a entity is soft-deleted in the deleted by column we insert the userId by default.
    Also many applications use userTenantId in the createdBy and modifyBy columns. So to maintain uniformity it should be configurable.

  2. loopback4-authentication : should not a part of peer-dependency in here.
    As it makes mandatory for user to use only this particular package for authentication.
    All our sourecloop packages should be independent.
samarpanB pushed a commit that referenced this issue Oct 31, 2022
feat(repository): allow deletedBy id to be configurable
a699aef 
BREAKING CHANGE:
remove dependency of loopback4-authentication

gh-99
samarpanB pushed a commit that referenced this issue Oct 31, 2022
feat(repository): allow deletedBy id to be configurable
831fa8f 
BREAKING CHANGE:
remove dependency of loopback4-authentication

gh-99
@samarpan-b samarpan-b mentioned this issue Oct 31, 2022
Merged
11 tasks
samarpan-b added a commit that referenced this issue Nov 2, 2022
@samarpan-b
feat(repository): allow deletedBy id to be configurable (#100)
1be1dc4 
BREAKING CHANGE:
remove dependency of loopback4-authentication

gh-99
samarpanB pushed a commit that referenced this issue Nov 6, 2022
feat(repository): allow deletedBy id to be configurable using class p…
28de1cd 
…rotected property

BREAKING CHANGE:
change approach of deletedById key provider

gh-99
@yeshamavani
Copy link
Contributor Author

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaghavaroraSF RaghavaroraSF

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(repository): allow deletedBy id to be configurable sourcefuse/loopback4-soft-delete
2 participants
@yeshamavani @RaghavaroraSF