Adjusted labels for clarity and accessibility.

[soup-bowl]

Issue #51 raised by @kebbet highlights an important oversight that doesn't follow the standard of the rest of the WordPress administration dashboard, being that not only are labels missing from checkboxes, but the label-for in the settings key column were left undefined.

This PR adjusts the generation functions to make them less of a catch-all approach, and also allows the group of sporadic check boxes to be group together. The PR affects both single-site and multisite settings equally.

@kebbet if you wouldn't mind verifying if this is what you were expecting, especially as it adds more labels that will ultimately need translating and I don't want to add unnecessary burden if it's wrong.

Settings Checkbox Group

Before

After

Additionals

Additional adjustments

• Multisite over-ride on settings generation now an inherited trait rather than a function argument.
• Debug setting source indicators use the badges from mail view to help isolate their presences.

[kebbet]

Thanks for doing this! Will have a look and do a test run if I have the time during next week!

[kebbet]

Just read the code, have not tested it, don't know how to fetch a pull request... 😂

[soup-bowl]

@kebbet Appreciate that one of your main points is that description should be used to identify the optional under-field info instead of the text alongside a checkbox. Now you've highlighted it, I've used subtext completely wrong by definition anyway.

Barring any better words, how about fieldside_text for the checkbox text variable name?

[kebbet]

@kebbet Appreciate that one of your main points is that description should be used to identify the optional under-field info instead of the text alongside a checkbox. Now you've highlighted it, I've used subtext completely wrong by definition anyway.

Barring any better words, how about fieldside_text for the checkbox text variable name?

Much clearer with fieldside_text.

[soup-bowl]

Side note, I recently hooked up my Visual Studio Code to GitHub, and all your comments have appeared directly in my editor. Super neat!

[kebbet]

Side note, I recently hooked up my Visual Studio Code to GitHub, and all your comments have appeared directly in my editor. Super neat!

Nice, I tried it too and can now see PR's and comments! Thanks!
I have integrated Bitbucket in VSC before, which works nicely!

[soup-bowl]

Apologies, I clicked the re-review button I'm not sure it did anything? Made changes, if you're happy I can merge this in.

Only uncommented thing is class-multisite.php:86, the multisite definition of email disabling is different to reflect disabling all multisite emails.

[kebbet]

Small things. Looks nice overall!

[soup-bowl]

Fab - will merge in. Thanks for all your help! 😄