Skip to content

network: ensure connect request will get submitted #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soulxu merged 1 commit into from
Nov 10, 2022
Merged

network: ensure connect request will get submitted #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions source/common/network/io_uring_socket_handle_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,10 +228,8 @@ Api::SysCallIntResult IoUringSocketHandleImpl::connect(Address::InstanceConstSha
res = uring.prepareConnect(fd_, address, req);
RELEASE_ASSERT(res == Io::IoUringResult::Ok, "unable to prepare connect");
}
if (isLeader()) {
// TODO(rojkov): handle `EBUSY` in case the completion queue is never reaped.
uring.submit();
}
// Need to ensure the connect request submitted.
uring.submit();
return Api::SysCallIntResult{0, SOCKET_ERROR_IN_PROGRESS};
}

Expand Down