Acquisition star ID and one-shot monitor (not for merge) #105
+153
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
reviewed
May 2, 2018
| .format(event['stop'], obsid), | ||
| 'message': message}) | ||
|
|
||
| if event['n_id'] <= 5: |
There was a problem hiding this comment.
I'd be comfortable setting this to <= 4 at this point (assuming we keep up with performance trending).
|
Closed, replaced by #149 as a placeholder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently running via kadi (aldcroft) as:
This cannot be easily integrated with the production kadi because of the different cron schedule and dependence on maude, but it is certainly possible. Probably worth evaluating (6 months on) whether it's worth making this a permanent thing.