Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back most of fetch module contents to __all__ #274

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Feb 26, 2025

Description

Fixes an issue where some code is relying on module attributes in fetch_eng that were removed in #269.

Interface impacts

Adds back symbols to the public API that were removed.

Testing

Unit tests

  • Mac
(ska3-flight-2025.0rc2) ➜  cheta git:(add-back-all-exports) git rev-parse --short HEAD
e0432f3
(ska3-flight-2025.0rc2) ➜  cheta git:(add-back-all-exports) pytest
================================================ test session starts =================================================
platform darwin -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /Volumes/git
configfile: pytest.ini
plugins: hypothesis-6.125.2, doctestplus-1.3.0, anyio-4.7.0, timeout-2.3.1
collected 175 items                                                                                                  

cheta/tests/test_comps.py ............................................................                         [ 34%]
cheta/tests/test_data_source.py .........                                                                      [ 39%]
cheta/tests/test_fetch.py .................................                                                    [ 58%]
cheta/tests/test_intervals.py .........................                                                        [ 72%]
cheta/tests/test_orbit.py .                                                                                    [ 73%]
cheta/tests/test_remote_access.py ......                                                                       [ 76%]
cheta/tests/test_sync.py ........                                                                              [ 81%]
cheta/tests/test_units.py ...........                                                                          [ 87%]
cheta/tests/test_units_reversed.py ...........                                                                 [ 93%]
cheta/tests/test_utils.py ...........                                                                          [100%]

========================================== 175 passed in 193.33s (0:03:13) ===========================================

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@taldcroft taldcroft requested a review from jskrist February 26, 2025 20:26
Copy link
Member

@jskrist jskrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my purposes (remote access to cheta telemetry data remotely from Windows), these changes work.

I noticed the following differences from version 4.62.3:

missing the following properties from the module:

  • 'CACHE',
  • 'DateTime',
  • 'ENG_ARCHIVE',
  • 'MAX_GLOB_MATCHES',
  • 'ft'

added one new property:

  • 'filetypes_tbl'

these differences do not impact my use at all, but am noting them incase they are not expected/intended differences.

@taldcroft taldcroft merged commit a4af477 into master Feb 27, 2025
2 checks passed
@taldcroft taldcroft deleted the add-back-all-exports branch February 27, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants