Add RBI support #135
Draft
Add RBI support #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasmarshall
force-pushed
the
add-rbi-support
branch
from
a05b597
to
4e54a05
Compare
thomasmarshall
force-pushed
the
add-rbi-support
branch
from
4e54a05
to
b1ad132
Compare
|
Here's a video demonstrating "go to definition" but it relies on a workaround using an internal Monaco API. I tried to update Screen.Recording.2024-06-21.at.19.42.40.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for RBI files. This could be useful for sharing or reproducing RBI specific functionality (e.g. sig overloads). It uses a new
--rbicommand line arg, so requires a new build of sorbet-wasm. I've added a temporary commit with my custom sorbet-wasm build based off this PR, but can remove that and add a real build before merging.Screen.Recording.2024-06-20.at.20.28.47.mov