[FEATURE] 공홈 어드민 공통 페이지 퍼블리싱 #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. org admin global type 생성 2. title 및 nav 생성
eonseok-jeon
requested review from
jungwoo3490,
sohee-K,
lydiacho,
Brokyeom,
wuzoo and
suwonthugger
eonseok-jeon
force-pushed
the
feature-org-admin-common-3
branch
from
a21875c
to
d264df4
Compare
eonseok-jeon
changed the title
eonseok-jeon
changed the title
|
요거 나머지 1번 2번 PR이랑 차이점이 있을까요? |
없습니다! 코리 반영하였고, 1,2,3 통합 해달라 하셔서 통합했어여~ |
eonseok-jeon
changed the title
lydiacho
approved these changes
Nov 2, 2024
| })} | ||
| id={id} | ||
| type="text" | ||
| placeholder="ex. #ffffff" |
There was a problem hiding this comment.
이거 픽마 보니까 # 이 없더라구요! #을 넣어야 하는지 말아야할지 헷갈려서 디자인처럼 아예 빼주는게 조을것같아요
그리고 maxLength 6으로 제한해줘도 좋을거같아여!
There was a problem hiding this comment.
input type color의 value는 앞에 #를 자동으로 포함시키는데 그러면 해당 value를 ui에 렌더링 할 때 #를 빼주는 과정을 추가해줘야 해요
근데 이걸 다시 공홈에 적용할 때는 #를 추가해줘야 하는데 불필요한 과정인 거 같다는 생각이 들어요
그래서 그냥 #을 처음부터 냅두는 방식이 더 편할 거 같아요!
피그마 역시도 원래는 #ffffff로 나왔었는데 나중에 빠진 거 같네요
다시 추가해 달라고 부탁해보겠습니다
max length는 9로 설정했어요
# + 6 + 2 (투명도) 까지 고려해줬어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 구현 기능 명세
✅ PR Point
zod는 이후 로직 붙일 때 도입 할게여 :)
mds Radio, TextField, TextField - error message, colors, icon으로 다 변환했어요!
코드리뷰도 다 반영했습니다!
변경사항이 많아 리뷰 하기 힘들게 되었는데 죄송해여ㅜ
다음부턴 주의하면서 하겠습니다,,