Skip to content

Commit

Permalink
Remove flow assert: (XRPLF#5009)
Browse files Browse the repository at this point in the history
Rounding in the payment engine is causing an assert to sometimes fire
with "dust" amounts. This is causing issues when running debug builds of
rippled. This issue will be addressed, but the assert is no longer
serving its purpose.
  • Loading branch information
seelabs authored and sophiax851 committed Jun 12, 2024
1 parent 7d5842c commit 83c52bf
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion src/ripple/app/paths/impl/StrandFlow.h
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,13 @@ flow(
{
if (actualOut > outReq)
{
assert(0);
// Rounding in the payment engine is causing this assert to
// sometimes fire with "dust" amounts. This is causing issues when
// running debug builds of rippled. While this issue still needs to
// be resolved, the assert is causing more harm than good at this
// point.
// assert(0);

return {tefEXCEPTION, std::move(ofrsToRmOnFail)};
}
if (!partialPayment)
Expand Down

0 comments on commit 83c52bf

Please sign in to comment.