New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: quote command and args if needed #2

Merged

Shin-Ogata merged 1 commit into sony:master from t-hiroishi:fix_exec_command

Nov 21, 2017

Contributor

t-hiroishi commented Nov 15, 2017 •

edited

Loading

fix execCommand() function on win32 env


          fixed: quote command and args if needed

2a96478

Member

Shin-Ogata commented Nov 21, 2017

LGTM

this issue caused by followings.

nodejs/node#7367
https://nodejs.org/dist/latest-v8.x/docs/api/child_process.html#child_process_spawning_bat_and_cmd_files_on_windows

Shin-Ogata merged commit 60d178d into sony:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet