chore: update go-ethereum up to 1.8.2#511
Closed
nikonov1101 wants to merge 1 commit into
Closed
Conversation
Why? `go-ethereum` now have the events filters (ethereum/go-ethereum#15832), so we doesnt need to do not-so-smart polling from the blockchain. As a next step, we need to rewrite some of `blockchain/api.go` internals and use new event filters. Changed: - A lot of new stuff is shipped into ./vendor. - Minor fixes to match new go-ethereum API (gas price is represented as uint64, not big.Int). - `insonmnia/npp/puncher.go` is updated because of vet is not happy (`addr` variable shadowing).
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
=======================================
Coverage 25.61% 25.61%
=======================================
Files 95 95
Lines 7487 7487
=======================================
Hits 1918 1918
Misses 5359 5359
Partials 210 210
Continue to review full report at Codecov.
|
Member
Author
|
Closing because out of scope for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
go-ethereumnow have the events filters (ethereum/go-ethereum#15832), so we doesnt need to do not-so-smart polling from the blockchain.As a next step, we need to rewrite some of
blockchain/api.gointernals and use new event filters.Changed:
insonmnia/npp/puncher.gois updated because of vet is not happy (addrvariable shadowing).