Skip to content

Conversation

lilyinstarlight
Copy link
Contributor

@lilyinstarlight lilyinstarlight commented Jun 8, 2022

@samaaron for using precompiled assets instead of running esbuild/tailwind/etc during build, do you just want the results from mix assets.deploy.prod committed to the repo?

If so we can remove those files from the clean scripts, gitignore, etc and just let them get committed. This PR does that plus make a few other misc changes to keep things consistent after e907632 and 5b8bc5b

Specific changes in this PR:

  • Ignore precompiled assets in clean scripts
  • Remove precompiled assets from gitignore
  • Run assets.deploy.prod mix command when doing pre-tau-dev-init
  • Remove assets.deploy.prod command from linux offline build and add deps.compile
  • Respect MIX_DEPS_PATH from tailwind config
  • Remove reliance on tailwind/esbuild dependencies in test env

@samaaron
Copy link
Collaborator

samaaron commented Jun 8, 2022

Yep, this looks very much like the direction I was heading in. This stuff is still very much in an embryonic form and It's not even featuring in v4. However, the tech is all there just to make sure that the foundations are there in a form that can serve existing needs and to be ready for activity post v4's release.

I'm sure there will be much more manipulation of this kind of stuff going forwards as we start building actual user-facing functionality :-)

@lilyinstarlight lilyinstarlight force-pushed the fix/precompiled-assets branch from c5d5ed5 to 9462c7b Compare June 8, 2022 17:06
@lilyinstarlight
Copy link
Contributor Author

Alright, if this is what you had in mind, I'll mark this ready for review after I push a few more changes. I noticed CI started timing out after 5b8bc5b for macOS and Linux, so I may try to investigate that if I have time today. It might be related to not having precompiled files it expects to exist when starting Tau (since Tau is what is failing to start judging by logs, which causes CI to hang like this)

@lilyinstarlight lilyinstarlight force-pushed the fix/precompiled-assets branch from 9462c7b to b7dbdf2 Compare June 8, 2022 18:02
@lilyinstarlight
Copy link
Contributor Author

lilyinstarlight commented Jun 8, 2022

Okay, I think I've fixed the CI issue. The tailwind and esbuild tasks were unavailable for mix assets.deploy.dev when MIX_ENV=test because of the only: :dev specifier, so I updated those to use only: [:dev, :test]
Edit: Alternatively we can just remove the mix assets.deploy.dev command from the Tau test env in boot-{lin,mac,win} scripts since we don't expect them to be generated at runtime anymore. After thinking about it that actually seems like a more sensible solution

Updates:
* ignore precompiled assets in clean scripts
* remove precompiled assets in gitignore
* run `assets.deploy.prod` mix command when doing pre-tau-dev-init
* remove `assets.deploy.prod` command from linux offline build and add
  `deps.compile`
* respect MIX_DEPS_PATH from tailwind config
* remove reliance on tailwind/esbuild in test env
@lilyinstarlight lilyinstarlight force-pushed the fix/precompiled-assets branch from b7dbdf2 to f3cee6e Compare June 8, 2022 18:53
@lilyinstarlight lilyinstarlight marked this pull request as ready for review June 8, 2022 20:53
@samaaron samaaron merged commit 67d2c4e into sonic-pi-net:dev Jun 12, 2022
@samaaron
Copy link
Collaborator

Wonderful, thank-you so much for this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants