GUI - miscellaneous Qt Tau/PhX widget fixes #3018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes messages like ``` Release of profile requested but WebEnginePage still not deleted. Expect troubles ! ``` indicating webview destruction order issues and ``` QLayout: Attempting to add QLayout "" to PhxWidget "", which already has a layout ``` indicating a widget layout was attempted to be overridden
|
Yeah, good call - looks like Qt6 on Linux is still a little way off :-) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build change allows using Qt5 WebEngine for the Tau/PhX widget. Even though we only want to support Qt6 WebEngine, it still works just fine with Qt5 and this is a low-maintenance change and won't affect official builds (also the feature is disabled by default). I'm mostly wanting this so I can continue to play with the widget on my system which does not yet support Qt6
The second change fixes Qt object parenting and layout assignment which were causing the following runtime errors in the console
Object destruction order error, fixed by reversing the order the objects are assigned to the parent:
Layout attempted to be overridden error, fixed by only setting the layout for
PhxWidget(via theQBoxLayoutconstructor) once:Edit: CI will be failing until erlef/setup-beam#91 is merged because it looks like the Windows builds default to
windows-2022now, for which support in the BEAM action is not merged yet