-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-asic support for dropconfig #3735
Open
arista-hpandya
wants to merge
2
commits into
sonic-net:master
Choose a base branch
from
arista-hpandya:multi-asic-dropconfig
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add multi-asic support for dropconfig #3735
arista-hpandya
wants to merge
2
commits into
sonic-net:master
from
arista-hpandya:multi-asic-dropconfig
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
arista-hpandya
force-pushed
the
multi-asic-dropconfig
branch
from
January 27, 2025 23:27
1a8c9ea
to
4f38e99
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
arista-hpandya
force-pushed
the
multi-asic-dropconfig
branch
from
January 28, 2025 16:57
1818a66
to
b5a9fcb
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
arista-hpandya
force-pushed
the
multi-asic-dropconfig
branch
from
January 28, 2025 22:26
b5a9fcb
to
06444ac
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@arlakshm @wenyiz2021 for awareness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This script was missed during the initial efforts to add multi-asic support.
How I did it
This is in accordance to the issue sonic-net/sonic-buildimage#15148 which tracks the multi-asic support for scripts in sonic-utilities.
How to verify it
The changes were verified by:
Running all the unit tests in sonic-utilities
Verifying the changes manually on a single-asic linecards
Verifying the changes manually on a multi-asic linecards
Screenshots of the manual tests:
Previous command output (if the output of a command-line utility has changed)
Single asic command outputs remain untouched
New command output (if the output of a command-line utility has changed)
New multi asic command outputs will start with the prefix: `For namespace: "