Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear fabric counters queue/port #2892

Merged
merged 5 commits into from
Aug 19, 2023
+270 −44
Merged

Clear fabric counters queue/port #2892

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
621b275
Clear fabric counters queue/port
kenneth-arista Jul 5, 2023
fa00dd6
Fixed params to get_result_and_return_code
kenneth-arista Jul 5, 2023
98dd3d6
Correct command definition
kenneth-arista Jul 17, 2023
72aaca6
Merge branch 'master' into master-clear-fabric-counters
qiluo-msft Jul 19, 2023
95ad6e3
Add a message before early return when issuing the clear counter command
jfeng-arista Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed params to get_result_and_return_code
@kenneth-arista
kenneth-arista committed Jul 17, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit fa00dd69fbdce1588aa02dd3c4c377d6da765172
18 changes: 9 additions & 9 deletions tests/fabricstat_test.py
View file
Original file line number Diff line number Diff line change
@@ -159,7 +159,7 @@ def setup_class(cls):
os.environ["UTILITIES_UNIT_TESTING"] = "1"

def test_single_show_fabric_counters(self):
return_code, result = get_result_and_return_code('fabricstat -D')
return_code, result = get_result_and_return_code(['fabricstat', '-D'])
assert return_code == 0

return_code, result = get_result_and_return_code(['fabricstat'])
@@ -169,19 +169,19 @@ def test_single_show_fabric_counters(self):
assert result == multi_asic_fabric_counters_asic0

def test_single_clear_fabric_counters(self):
return_code, result = get_result_and_return_code('fabricstat -C')
return_code, result = get_result_and_return_code(['fabricstat', '-C'])
print("return_code: {}".format(return_code))
print("result = {}".format(result))
assert return_code == 0
assert result.rstrip() == clear_counter

return_code, result = get_result_and_return_code('fabricstat')
return_code, result = get_result_and_return_code(['fabricstat'])
print("return_code: {}".format(return_code))
print("result = {}".format(result))
assert return_code == 0
assert result == multi_asic_fabric_counters_asic0_clear

return_code, result = get_result_and_return_code('fabricstat -D')
return_code, result = get_result_and_return_code(['fabricstat', '-D'])
assert return_code == 0

@classmethod
@@ -237,21 +237,21 @@ def test_multi_show_fabric_counters_queue_asic(self):
assert result == multi_asic_fabric_counters_queue_asic0

def test_multi_show_fabric_counters_queue_clear(self):
return_code, result = get_result_and_return_code('fabricstat -C -q')
return_code, result = get_result_and_return_code(['fabricstat', '-C', '-q'])
print("return_code: {}".format(return_code))
print("result = {}".format(result))
assert return_code == 0

return_code, result = get_result_and_return_code('fabricstat -q -n asic0')
return_code, result = get_result_and_return_code(['fabricstat', '-q', '-n', 'asic0'])
print("return_code: {}".format(return_code))
print("result = {}".format(result))
assert return_code == 0
assert result == multi_asic_fabric_counters_queue_asic0_clear

return_code, result = get_result_and_return_code('fabricstat -D')
return_code, result = get_result_and_return_code(['fabricstat', '-D'])
assert return_code == 0

return_code, result = get_result_and_return_code('fabricstat -q -n asic0')
return_code, result = get_result_and_return_code(['fabricstat', '-q', '-n', 'asic0'])
print("return_code: {}".format(return_code))
print("result = {}".format(result))
assert return_code == 0
@@ -296,7 +296,7 @@ def test_clear_command(self):
result = runner.invoke(clear.cli.commands["fabriccountersport"], [])
assert result.exit_code == 0

return_code, result = get_result_and_return_code('fabricstat -D')
return_code, result = get_result_and_return_code(['fabricstat', '-D'])
assert return_code == 0

@classmethod