Add fabric_ns to the ns_list when display_option is DISPLAY_ALL. #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
arlakshm
approved these changes
Mar 31, 2023
yxieca
pushed a commit
that referenced
this pull request
Apr 5, 2023
#2717) The get_ns_list_based_on_options function only gets front_ns and back_ns in current code. This change adds fabric_ns in the ns_list when display_option is DISPLAY_ALL. This enables the fabric related tests on voq chassis, e.g the change in sonic-net/sonic-mgmt#6620
StormLiangMS
pushed a commit
that referenced
this pull request
Apr 20, 2023
#2717) The get_ns_list_based_on_options function only gets front_ns and back_ns in current code. This change adds fabric_ns in the ns_list when display_option is DISPLAY_ALL. This enables the fabric related tests on voq chassis, e.g the change in sonic-net/sonic-mgmt#6620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_ns_list_based_on_options function only gets front_ns and back_ns in current code.
This change adds fabric_ns in the ns_list when display_option is DISPLAY_ALL. This enables the fabric related tests on voq chassis, e.g the change in sonic-net/sonic-mgmt#6620
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)