Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for pfcwd_sw_enable in db_migrator_test #2253

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

bingwang-ms
Copy link
Contributor

What I did

This PR is to fix the input and output for testing the migration of pfcwd_sw_enable.
Before this change,

resulting_table = dbmgtr.configDB.get_table('PORT_QOS_MAP')
expected_table = expected_db.cfgdb.get_table('PORT_QOS_MAP')

resulting_table and expected_table are always empty {}. So the test case can always pass.

How I did it

Fix the input and output for testing the migration of pfcwd_sw_enable.

How to verify it

Run UT for db_migrator after update.

collected 75 items                                                                                                                                                                                    

tests/db_migrator_test.py ...........................................................................                                                                                           [100%]

===================================================================================== 75 passed in 17.14 seconds ======================================================================================

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@bingwang-ms bingwang-ms merged commit 27667cf into sonic-net:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants