Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config/load_mgmt_config] Support load IPv6 mgmt IP #2206

Merged
merged 8 commits into from
Jul 1, 2022
Merged

[config/load_mgmt_config] Support load IPv6 mgmt IP #2206

merged 8 commits into from
Jul 1, 2022

Conversation

Blueve
Copy link
Contributor

@Blueve Blueve commented Jun 10, 2022 •
edited
Loading

What I did

Support load both IPv4 and IPv6 management address.

This PR requires sonic-net/sonic-buildimage#11095

How I did it

Iterate all mgmt intf config from device_desc.xml and apply them all.

How to verify it

  • UT

Local UT run result (w/ sonic-buildimage change sonic-net/sonic-buildimage#11095)

tests/config_test.py::TestConfigLoadMgmtConfig::test_config_load_mgmt_config_ipv4_only PASSED                                                                                                                  [ 15%]
tests/config_test.py::TestConfigLoadMgmtConfig::test_config_load_mgmt_config_ipv6_only PASSED                                                                                                                  [ 15%]
tests/config_test.py::TestConfigLoadMgmtConfig::test_config_load_mgmt_config_ipv4_ipv6 PASSED

Back Port

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@Blueve Blueve marked this pull request as ready for review June 23, 2022 14:32
Blueve
Blueve commented Jun 27, 2022
View reviewed changes
@Blueve
Copy link
Contributor Author

Blueve commented Jun 29, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Blueve
Copy link
Contributor Author

Blueve commented Jun 29, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Blueve
Copy link
Contributor Author

Blueve commented Jun 29, 2022

Artifacts still not update to date yet, I will retry tomorrow

@Blueve
Copy link
Contributor Author

Blueve commented Jul 1, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Blueve Blueve merged commit b5d6659 into sonic-net:master Jul 1, 2022
@Blueve Blueve deleted the dev/jika/mgmt_v6 branch July 1, 2022 09:20
Blueve added a commit to Blueve/sonic-utilities that referenced this pull request Jul 1, 2022
@Blueve
[config/load_mgmt_config] Support load IPv6 mgmt IP (sonic-net#2206)
03ae3b0 
* [config/load_mgmt_config] Support load IPv6 mgmt IP

Signed-off-by: Jing Kan [email protected]
@Blueve Blueve mentioned this pull request Jul 1, 2022
Merged
Blueve added a commit to Blueve/sonic-utilities that referenced this pull request Jul 1, 2022
@Blueve
[config/load_mgmt_config] Support load IPv6 mgmt IP (sonic-net#2206)
fcced70 
* [config/load_mgmt_config] Support load IPv6 mgmt IP

Signed-off-by: Jing Kan [email protected]
dprital added a commit to dprital/sonic-utilities that referenced this pull request Jul 3, 2022
@dprital
[202012_7_rc_1_20220703] [cherry-pick][202012][config/load_mgmt_confi…
e9789e0 
…g] Support load IPv6 mgmt IP (sonic-net#2206)
@Blueve Blueve mentioned this pull request Jul 4, 2022
Merged
1 task
Blueve added a commit that referenced this pull request Jul 5, 2022
@Blueve
[cherry-pick][202012][config/load_mgmt_config] Support load IPv6 mgmt…
62c1640 
… IP (#2206) (#2245)

Signed-off-by: Jing Kan [email protected]
Blueve added a commit that referenced this pull request Jul 5, 2022
@Blueve
[config/load_mgmt_config] Support load IPv6 mgmt IP (#2206) (#2246)
09b4678 
Signed-off-by: Jing Kan [email protected]
yxieca pushed a commit that referenced this pull request Jul 5, 2022
@Blueve @yxieca
[config/load_mgmt_config] Support load IPv6 mgmt IP (#2206)
6ebba53 
* [config/load_mgmt_config] Support load IPv6 mgmt IP

Signed-off-by: Jing Kan [email protected]
Blueve added a commit to Blueve/sonic-utilities that referenced this pull request Jul 7, 2022
@Blueve
[config/load_mgmt_config] Support load IPv6 mgmt IP (sonic-net#2206) (s…
4a228f2 
…onic-net#2246)

Signed-off-by: Jing Kan [email protected]
@Blueve Blueve mentioned this pull request Jul 7, 2022
Merged
1 task
@neethajohn neethajohn mentioned this pull request Jul 8, 2022
Merged
neethajohn added a commit to sonic-net/sonic-buildimage that referenced this pull request Jul 11, 2022
@neethajohn
[202012] Submodule update for sonic-utilities (#11400)
ec7cc16 
Signed-off-by: Neetha John <[email protected]>

This PR contains the following commits
5a54bd7 Added cisco config platform commands (sonic-net/sonic-utilities#2241)
62c1640 [config/load_mgmt_config] Support load IPv6 mgmt IP (sonic-net/sonic-utilities#2206)
c061a18 Fix header for the output table following 'show ipv6 interface' command (sonic-net/sonic-utilities#2219)
ecca18ff [202012] Update load minigraph to load backend acl (sonic-net/sonic-utilities#2235)
Blueve added a commit that referenced this pull request Jul 12, 2022
@Blueve
[config/load_mgmt_config] Support load IPv6 mgmt IP (#2206) (#2246) (#…
02eb899 
…2256)

Signed-off-by: Jing Kan [email protected]
@saksarav-nokia saksarav-nokia mentioned this pull request Jan 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxieca yxieca yxieca approved these changes

Assignees
No one assigned
Labels
Included in 202205 Branch Request for 202111 Branch Request for 202205 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blueve @yxieca