[config/config_mgmt.py]: Fix dpb issue with upper case mac in device_metadata. #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveen-li
force-pushed
the
fix_upper_case_mac_dpb
branch
3 times, most recently
from
9768648 to
8fcfda7
Compare
|
Look like a issue while running VS test in Pipeline. Any POC who can help to resolve it. |
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Had a look at test failures, the test are not DPB related. Need to re-run Pipeline. |
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgsudharsan
previously approved these changes
Mar 16, 2022
|
@qiluo-msft Can you please review these changes? |
qiluo-msft
previously approved these changes
Mar 18, 2022
|
@praveen-li Can you please sync to the latest master? The vs-tests shouldn't run there and it should unblock this PR |
|
Need @praveen-li help to fix the build failure. |
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@praveen-li Can you please sync to latest sonic-utilities? The pipeline will not have vstests |
device_metadata. libYang converts ietf yang types to lower case internally,which creates false config diff for us while DPB. This PR fixes the issue by not precessing false diff. Related issue" sonic-net/sonic-buildimage#9478 Signed-off-by: Praveen Chaudhary <[email protected]>
praveen-li
force-pushed
the
fix_upper_case_mac_dpb
branch
from
8fcfda7 to
53b19bd
Compare
dgsudharsan
approved these changes
Apr 5, 2022
|
@qiluo-msft The pipelines pass now. Can you please help in merging this? |
qiluo-msft
approved these changes
Apr 8, 2022
|
Did this PR fix "Related issue"? |
Yes it did |
judyjoseph
pushed a commit
that referenced
this pull request
Apr 11, 2022
device_metadata. libYang converts ietf yang types to lower case internally,which creates false config diff for us while DPB. This PR fixes the issue by not precessing false diff. Related issue" sonic-net/sonic-buildimage#9478 #### What I did fixes issue: sonic-net/sonic-buildimage#9478 #### How I did it libYang converts ietf yang types to lower case internally,which creates false config diff for us while DPB. Example: For DEVICE_METADATA['localhost']['mac'] type is yang:mac-address. Libyang converts from 'XX:XX:XX:E4:B3:DD' -> 'xx:xx:xx:e4:b3:dd' so args for function _recurCreateConfig in this case will be: diff = DEVICE_METADATA['localhost']['mac'] where DEVICE_METADATA': {'localhost': {'mac': ['XX:XX:XX:E4:B3:DD', 'xx:xx:xx:e4:b3:dd']}}} Note: above dict is representation of diff in config given by diffJson library. out = 'XX:XX:XX:e4:b3:dd' inp = 'xx:xx:xx:E4:B3:DD' I add a check to avoid processing of such config diff for DPB. #### How to verify it Added a unit test. Build time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libYang converts ietf yang types to lower case internally,which
creates false config diff for us while DPB.
This PR fixes the issue by not precessing false diff.
Related issue"
sonic-net/sonic-buildimage#9478
Signed-off-by: Praveen Chaudhary [email protected]
What I did
fixes issue: sonic-net/sonic-buildimage#9478
How I did it
How to verify it
Added a unit test. Build time.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)