[test]: Fix test_mirror with correct number of ACL tables #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After creation of the ACL table, check both the number of ACL tables and the number of ACL table groups. After removal of the ACL table, correct the number of remaining ACL tables. Right now, after the ACL table is removed, the ACL table groups are not removed correspondingly. This should be fixed in the future. Signed-off-by: Shu0T1an ChenG <[email protected]>
|
will close this pull request, since #521 has changed part of the code here. i'll reevaluate all the changes. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Add below two commands: config acl add table <table_name> <table_type> config acl remove table <table_name> note: add table supports description and ports Signed-off-by: Shu0T1an ChenG <[email protected]>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
* Move ntf_queue to proper NotificationQueue class * Move command line options and parser to separate classes * Address comments * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After creation of the ACL table, check both the number of ACL tables
and the number of ACL table groups.
After removal of the ACL table, correct the number of remaining
ACL tables.
Right now, after the ACL table is removed, the ACL table groups are
not removed correspondingly. This should be fixed in the future.
Signed-off-by: Shu0T1an ChenG [email protected]