[vrf orchagent]: Add Request parser class and VRF orchagent based on it #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where it using, otherwise it would uninitialized
lguohan
reviewed
Jan 13, 2018
orchagent/vrforch.cpp
Outdated
| } | ||
|
|
||
| sai_object_id_t router_id; | ||
| sai_status_t status = sai_virtual_router_api->create_virtual_router(&router_id, |
There was a problem hiding this comment.
create_virtual_router [](start = 50, length = 21)
if the vrf exists, then we need to do a set operation, i think.
There was a problem hiding this comment.
You mean 'update' operation? Don't create a new vrf, but update existing one?
There was a problem hiding this comment.
ok. In this case 'update' operation might have two semantics:
- remove old attributes and add the new one from the request. Currently impossible in SAI (no function to remove attributes or setting them into default value).
- merge old attributes with new ones from the request..
I'll implement the second approach.
lguohan
reviewed
Jan 13, 2018
| { | ||
| std::vector<request_types_t> key_item_types; | ||
| std::unordered_map<std::string, request_types_t> attr_item_types; | ||
| std::vector<std::string> mandatory_attr_items; |
There was a problem hiding this comment.
std::vectorstd::string mandatory_attr_items; [](start = 4, length = 46)
I am ok with current implementation.
but, it would be more extensible to add different property for the attribute item, for example, the type, whether it is mandatory or not, whether it depends on other attribute item of not.
lguohan
reviewed
Jan 13, 2018
tests/test_vrf.py
Outdated
| # check that the vrf entry was removed | ||
| assert how_many_entries_exist(asic_db, "ASIC_STATE:SAI_OBJECT_TYPE_VIRTUAL_ROUTER") == 1, "The vrf wasn't removed" | ||
|
|
||
| # check that the correct vrv entry was removed |
There was a problem hiding this comment.
vrv [](start = 29, length = 3)
vrf
lguohan
requested changes
Jan 13, 2018
lguohan
reviewed
Jan 17, 2018
tests/request_parser_ut.cpp
Outdated
| } | ||
| // FIXME: add a test to test an unsupported key type and attr type REQ_T_NOT_USED | ||
| // FIXME: expect_no_throw for constructors | ||
| // FIXME: Add a test to test 'empry' attribute |
lguohan
approved these changes
Jan 17, 2018
lguohan
approved these changes
Jan 17, 2018
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…SONiC/issues/268)" (sonic-net#424) Signed-off-by: [email protected]
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…erface names (sonic-net#474) * Avoid shutdown/startup commands on invalid interface names * sonic-utilities: Fix bug in the show command to display a specific interface status * sonic-utilities: Check for the presence of interface in port table instead of the optional alias attribute * Addressed review comment for sonic-net#424 * Undone the change in intfutil file to push that fix in a seperate PR. * Corrected the error message string for 'config interface <invalid-interface-name> tartup/shutdown'. * [sonic-utilities] Fix to shutdown and startup on valid PortChannel interface names * [sonic-utilities] Allow shutdown/startup commands to be done using the alias names of PORTs.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Signed-off-by: Volodymyr Samotiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Implemented VRF orchagent.
Why I did it
To support virtual routers configurations on SONiC.
How I verified it
Usings tests/tests_vrf.py
Details if related
I've added a request parser (see orchagent/request_parser.cpp, orchagent/request_parser.h and tests/request_parser-ut.cpp). When using this class for any orchagent the class can parse and validate
request parameters for an orchagent. It allows us to create new orchagents faster with less errors.