Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore failure in setPortPfcAsym if SAI_STATUS_NOT_SUPPORTED #3430

Merged
merged 3 commits into from
Jan 6, 2025
+68 −3
Merged

Ignore failure in setPortPfcAsym if SAI_STATUS_NOT_SUPPORTED #3430

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fc1995
ignore failure in setPortPfcAsym if SAI_STATUS_NOT_SUPPORTED
zhixzhu Dec 17, 2024
0e26562
return true on setPortPfcAsym SAI_STATUS_NOT_SUPPORTED, since false w…
zhixzhu Dec 18, 2024
55cc479
add UT case PortPFCNotSupported
zhixzhu Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
return true on setPortPfcAsym SAI_STATUS_NOT_SUPPORTED, since false w… 
…ill make doPortTask keep repeating

Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
@zhixzhu
zhixzhu committed Dec 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 0e265620d1a558089d58fb5794d1896c5c06a8ec
2 changes: 1 addition & 1 deletion orchagent/portsorch.cpp
View file
Original file line number Diff line number Diff line change
@@ -2075,7 +2075,7 @@ bool PortsOrch::setPortPfcAsym(Port &port, sai_port_priority_flow_control_mode_t
SWSS_LOG_ERROR("Failed to set PFC mode %d to port id 0x%" PRIx64 " (rc:%d)", pfc_asym, port.m_port_id, status);
if (status == SAI_STATUS_NOT_SUPPORTED)
{
return false;
return true;
}
task_process_status handle_status = handleSaiSetStatus(SAI_API_PORT, status);
if (handle_status != task_success)