Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fabric capacity monitoring code. #3097

Merged

Conversation

jfeng-arista
Copy link
Contributor

@jfeng-arista jfeng-arista commented Apr 2, 2024

What I did
Add fabric capacity monitoring code.

The HLD can be found at
https://github.com/sonic-net/SONiC/blob/master/doc/voq/fabric.md

The current design does not cover the card hotswap/OIR cases. We will discuss how to handle that in a separate proposal.
Why I did it

How I verified it

Details if related

@jfeng-arista
Copy link
Contributor Author

need #3089 merged to build

Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good. Can we add UT for this?

@jfeng-arista jfeng-arista requested a review from prsunny as a code owner April 25, 2024 07:12
@jfeng-arista
Copy link
Contributor Author

changes look good. Can we add UT for this?

added

@jfeng-arista
Copy link
Contributor Author

I checked failures, and they are not Fabric related tests, let me restart the test pipeline

@jfeng-arista
Copy link
Contributor Author

/Azp run Azure.sonic-swss

Copy link

Commenter does not have sufficient privileges for PR 3097 in repo sonic-net/sonic-swss

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

the failed tests not related to fabric

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

2024-04-25T22:45:55.3666646Z test_mux.py::TestMuxTunnel::test_acl FAILED [ 25%]
2024-04-25T22:46:38.3148266Z test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_appl_db_proc_seq FAILED [ 50%]
2024-04-25T22:47:11.7348687Z test_mux.py::TestMuxTunnel::test_neighbor_miss[standby->ping_serv->active->resolve_entry->delete_entry-IPv6] FAILED [ 75%]
2024-04-25T22:49:30.8390555Z test_vnet.py::TestVnetOrch::test_vnet_orch_2 FAILED [ 25%]
2024-04-25T22:50:12.9072929Z test_twamp.py::TestTwampLight::test_SenderContinuousMulti FAILED [ 50%]
2024-04-25T22:50:46.0160473Z test_srv6.py::TestSrv6::test_srv6 FAILED [ 75%]
2024-04-25T22:51:39.4822773Z test_srv6.py::TestSrv6Mysid::test_mysid FAILED [ 80%]
2024-04-25T22:52:40.1379025Z test_srv6.py::TestSrv6::test_srv6 FAILED [ 90%]

above are the failed tests, looks like not related to this change

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-swss

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny merged commit c79fd93 into sonic-net:master Apr 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants