-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fabric capacity monitoring code. #3097
Add fabric capacity monitoring code. #3097
Conversation
need #3089 merged to build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good. Can we add UT for this?
added |
I checked failures, and they are not Fabric related tests, let me restart the test pipeline |
/Azp run Azure.sonic-swss |
Commenter does not have sufficient privileges for PR 3097 in repo sonic-net/sonic-swss |
/azpw run Azure.sonic-swss |
/AzurePipelines run Azure.sonic-swss |
Azure Pipelines successfully started running 1 pipeline(s). |
the failed tests not related to fabric |
/azpw run Azure.sonic-swss |
/AzurePipelines run Azure.sonic-swss |
Azure Pipelines successfully started running 1 pipeline(s). |
2024-04-25T22:45:55.3666646Z test_mux.py::TestMuxTunnel::test_acl FAILED [ 25%] above are the failed tests, looks like not related to this change |
/Azp run Azure.sonic-swss |
Azure Pipelines successfully started running 1 pipeline(s). |
What I did
Add fabric capacity monitoring code.
The HLD can be found at
https://github.com/sonic-net/SONiC/blob/master/doc/voq/fabric.md
The current design does not cover the card hotswap/OIR cases. We will discuss how to handle that in a separate proposal.
Why I did it
How I verified it
Details if related