Improve pytest speed by grouping 20 tests together. #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
changed the title
|
Can we mark this PR ready? or is there more work to be done? |
It didn't improve much. About 10 min for grouping 10, and about 20 min for grouping 20. BTW, the vs test seemed to be broken. |
I actually see it improved. VS test issue was due to compilation.. its resolved now. |
Change-Id: I5a5e9aea034fe371d41ac9ba7e112551df575471
mint570
changed the title
|
I don't see much improvement from 20 to 30. I will go with 20 then. @prsunny this pr is ready after all tests pass. |
|
@prsunny |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Aug 5, 2022
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
*Improve pytest speed by grouping 20 tests together
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Group 20 tests together in pytest.
Why I did it
Hope this can improve the speed.
How I verified it
Presubmit test
Details if related