[EVPN]Modified tunnel creation logic when creating tunnel in VRF-VNI map creation flow #2387
Conversation
…map creation flow During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI. Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request fixes 1 alert when merging 1d22020 into 33c420d - view on LGTM.com fixed alerts:
|
|
@srj102 , please review |
|
Please add a new test case instead of altering existing one. |
|
This pull request introduces 3 alerts and fixes 1 when merging 8e4ab43 into e9984d8 - view on LGTM.com new alerts:
fixed alerts:
|
There are 4 tests that create vlan- vni map followed by vrf - vni map. All these test follow the same sequence for initialization. So I modified only one test to reverse the order. Please also note that the test modified is in mellanox specific and so for the same test broadcom specific test is not modified which could also cover the scenario. |
|
This pull request fixes 1 alert when merging c68c238 into 4a6f940 - view on LGTM.com fixed alerts:
|
|
@tapashdas @srj102 @prsunny Please let me know if there are any more comments. |
Hi @tapashdas , @prsunny , @srj102 Can you please review and signoff? This is a critical bugfix required for us. |
…tunnel is not supported 2) Modified the tunnel counter polling interval to 10000 ms by default
|
This pull request fixes 1 alert when merging eafa891 into 3161eaa - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 29a3294 into 3161eaa - view on LGTM.com fixed alerts:
|
| auto port_tunnel_name = tunnel_orch->getTunnelPortName(src_vtep, true); | ||
| gPortsOrch->addTunnel(port_tunnel_name, tunnel_obj->getTunnelId(), false); | ||
| gPortsOrch->getPort(port_tunnel_name,tunPort); | ||
| gPortsOrch->addBridgePort(tunPort); |
There was a problem hiding this comment.
As discussed, lets move the bridgeport creation based on capability.
There was a problem hiding this comment.
Hi Prince. I have added the check. I will look into the test failures and update.
|
|
This pull request fixes 1 alert when merging 86f3ec3 into 3161eaa - view on LGTM.com fixed alerts:
|
…map creation flow (#2404) Same as PR #2387 - What I did To fix issue sonic-net/sonic-buildimage#11428 Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map when tunnel is created first time in the VRF-VNI map processing flow. Modified the tunnel stats interval to 10 sec Modified the logic to create bridge port for p2mp tunnel only when p2p tunnel is not supported - Why I did it During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI. - How I verified it Modified UT to add VRF-VNI map first and VLAN-VLAN map later
…map creation flow (#2404) Same as PR #2387 - What I did To fix issue sonic-net/sonic-buildimage#11428 Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map when tunnel is created first time in the VRF-VNI map processing flow. Modified the tunnel stats interval to 10 sec Modified the logic to create bridge port for p2mp tunnel only when p2p tunnel is not supported - Why I did it During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI. - How I verified it Modified UT to add VRF-VNI map first and VLAN-VLAN map later
…map creation flow (sonic-net#2404) Same as PR sonic-net#2387 - What I did To fix issue sonic-net/sonic-buildimage#11428 Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map when tunnel is created first time in the VRF-VNI map processing flow. Modified the tunnel stats interval to 10 sec Modified the logic to create bridge port for p2mp tunnel only when p2p tunnel is not supported - Why I did it During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI. - How I verified it Modified UT to add VRF-VNI map first and VLAN-VLAN map later
What I did
To fix issue sonic-net/sonic-buildimage#11428
Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map when tunnel is created first time in the VRF-VNI map processing flow.
Why I did it
During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI.
How I verified it
Modified UT to add VRF-VNI map first and VLAN-VLAN map later
Details if related