[acl]: Simplify AclOrch class locking schema. #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lock mutex only at the beginning of critical sections.
stcheng
approved these changes
May 5, 2017
|
|
Mutex is used to prevent any multiple access from different thread to AclOrch class data. We accessing AclOrch class from two threads. Main thread for write operations (create/delete tables, rules, counters) and counters thread to read counters. In both threads entry points are guarded with mutex. There is no chance that one thread will interrupt another in a middle of work. Can you please explain how it is possible to invalidate cont iterator and where? |
qiluo-msft
approved these changes
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock mutex only at the beginning of critical sections.