ZMQ based state tables #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuh-80
force-pushed
the
dev/liuh/zmq_state_table
branch
from
2080d27 to
1426d70
Compare
liuh-80
force-pushed
the
dev/liuh/zmq_state_table
branch
from
1426d70 to
8b7499c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
commented
Dec 9, 2022
qiluo-msft
reviewed
Apr 25, 2023
qiluo-msft
previously approved these changes
Apr 28, 2023
|
@jiahua-wang |
|
#778 should help passing the sairedis syncd unit test. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
PR blocked by docker API issue, fix PR here: #779 |
liuh-80
force-pushed
the
dev/liuh/zmq_state_table
branch
from
38f071c to
1ae2ae6
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
May 11, 2023
common/zmqclient.cpp
Outdated
| else | ||
| { | ||
| // for other error, send failed immediately. | ||
| auto message = "zmq send failed, endpoint: " + m_endpoint + ",error: " + to_string(rc); |
qiluo-msft
reviewed
May 11, 2023
common/zmqclient.cpp
Outdated
| else if (zmq_err == ETERM) | ||
| { | ||
| m_connected = false; | ||
| auto message = "zmq connection break, endpoint: " + m_endpoint + ",error: " + to_string(rc); |
qiluo-msft
reviewed
May 11, 2023
common/table.h
Outdated
| throw std::invalid_argument("Invalid table name separator"); | ||
| } | ||
|
|
||
| static std::string gettableSeparator(int dbId) |
There was a problem hiding this comment.
Fixed
Also change ZmqConsumerTable inherite TableBase
qiluo-msft
approved these changes
May 11, 2023
liuh-80
added a commit
to sonic-net/sonic-swss
that referenced
this pull request
May 12, 2023
…le. (#2562) **What I did** Improve Consumer interface to support ZMQ based Producer/Consumer table. **Why I did it** To improve route create performance, swsscommon lib will add ZMQ based Producer/Consumer table. Because currently Consumer interface only support Redis based Producer/Consumer table, so improve this interface to support ZMQ based Producer/Consumer table. ZMQ based Producer/Consumer table can find in this PR: sonic-net/sonic-swss-common#715 **How I verified it** Pass all UT. **Details if related**
liuh-80
added a commit
to liuh-80/sonic-swss
that referenced
this pull request
May 17, 2023
…le. (sonic-net#2562) **What I did** Improve Consumer interface to support ZMQ based Producer/Consumer table. **Why I did it** To improve route create performance, swsscommon lib will add ZMQ based Producer/Consumer table. Because currently Consumer interface only support Redis based Producer/Consumer table, so improve this interface to support ZMQ based Producer/Consumer table. ZMQ based Producer/Consumer table can find in this PR: sonic-net/sonic-swss-common#715 **How I verified it** Pass all UT. **Details if related**
liuh-80
added a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jun 8, 2023
…le. (#2562) (#2778) This is a cherry-pick PR for #2562 **What I did** Improve Consumer interface to support ZMQ based Producer/Consumer table. **Why I did it** To improve route create performance, swsscommon lib will add ZMQ based Producer/Consumer table. Because currently Consumer interface only support Redis based Producer/Consumer table, so improve this interface to support ZMQ based Producer/Consumer table. ZMQ based Producer/Consumer table can find in this PR: sonic-net/sonic-swss-common#715 **How I verified it** Pass all UT. **Details if related** <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** **Why I did it** **How I verified it** **Details if related**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add ZMQ based ProducerStateTable and CustomerStateTable, which is 15 times faster than Redis based tables.
For transfer 10000 route config, ZMQ based tables take 120ms, Redis based tables take 1796ms.
How I did it
Add ZMQ based ProducerStateTable and CustomerStateTable.
How to verify it
Add new UT to cover ZmqProducerStateTable and ZmqCustomerStateTable.
Pass all UT and E2E test cases.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Add ZMQ based ProducerStateTable and CustomerStateTable.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)