Fix: DBInterface::get() return nullable strings #516
Merged
+42
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
changed the title
arlakshm
previously approved these changes
Aug 2, 2021
kcudnik
reviewed
Aug 2, 2021
common/dbinterface.cpp
Outdated
Comment on lines
70
to
72
| return value == "None" ? shared_ptr<string>() : make_shared<string>(value); | ||
| }; | ||
| return blockable<std::string>(innerfunc, dbName, blocking); | ||
| return blockable<shared_ptr<string>>(innerfunc, dbName, blocking); |
There was a problem hiding this comment.
inconsistent namespace usage, std::shared_ptr in function return value vs shared_ptr in function body #Resolved
There was a problem hiding this comment.
same for std::string and string
kcudnik
approved these changes
Aug 3, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
judyjoseph
pushed a commit
that referenced
this pull request
Oct 4, 2021
Fix DBInterface::get() should return nullable strings, to align with redis-py behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.