Ported Marvell armhf build on amd64 host for debian buster to use cross-comp… #501
Conversation
…ilation instead of qemu emulation
|
I cannot read "The change I did to improve the building time ports Sonic armhf build on amd64 host for Marvell platform for debian buster to use cross-compilation on arm64 host for armhf target." Could you clarify or refine the words? What is wrong or non-optimized with original code? |
| @@ -29,7 +29,11 @@ AC_ARG_ENABLE(debug, | |||
| *) AC_MSG_ERROR(bad value ${enableval} for --enable-debug) ;; | |||
| esac],[debug=false]) | |||
| AM_CONDITIONAL(DEBUG, test x$debug = xtrue) | |||
| AM_CONDITIONAL(ARCH64, test `getconf LONG_BIT` = "64") | |||
| if test x$CONFIGURED_ARCH = xarmhf && test x$CROSS_BUILD_ENVIRON = xy; then | |||
There was a problem hiding this comment.
x$CONFIGURED_ARCH
Is it possible to generalize this rule?
The two varaibles are host arch and target arch. I believe you can get word size from them.
Usually you use "getconf LONG_BIT" linux command in the building environment to figure out whether the target architecture is 64 bit. However when you are using cross-compilation inside native amd64 slave image running "getconf LONG_BIT" will return info about host rather than target. The only way I see is to check directly the target architecture and whether the building environment is cross-compilation. Please suggest your solution if this is not good enough.
I'll try to explain. Currently (before my change) when you want to build Sonic for armhf on amd64 host you first create slave docker image for armhf (meaning all executable inside the docker image are of armhf architecture). And then you build Sonic inside this slave armhf (architecture) docker as if you are on the native armhf host. However you can't run armhf binary (from within the slave docker) on the amd64 host directly. You need to use qemu emulation for every bit of armhf executable. For example when you compile with gcc, this gcc is armhf gcc and to run it you need to run "qemu gcc" using emulation. Emulation is extremely slow, so it causes the entire Sonic build for armhf on amd64 host take 22-24 hours. My change basically replaces the emulation with cross-compilation that is as fast as native compilation. So using the cross-compilation make Sonic build for armhf on amd64 host to complete in about 6 hours only. |
|
Dear reviewers, Long time has passed since this PR was raised. Please make progress on the review. Thanks, Gregory |
|
@qiluo-msft, what is blocking this pr? what do you want @gregshpit to do? |
|
Please resolve the conflict. |
Done. |
Rebased with the module master repository.
|
Hi, please merge this PR asap. I had to make another commit to sync with the master. Gregory |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Revert to the previous commit, discarding the last mistaken commit
|
Hi @qiluo-msft , Can we finally merge my changes ? Is there anything you expect from me todo ? Thanks, Gregory |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
HI @qiluo-msft, As far as I understand the tests failure is not related to my changes. Also I asked you already several times to answer my comments in this PR sonic-net/sonic-buildimage#8035. I need your help in resolving 3 remaining issues you asked me to fix. Please answer me asap. I can't proceed to final commit without it. Thanks a lot, Gregory |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 501 in repo Azure/sonic-swss-common |
|
/azpw run Azure.sonic-swss-common |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…SmartSwitch (sonic-net#501) * Modify APIs and add new APIs for supporting reboot on a SmartSwitch * Rename dpu_name to module_name to address the review comments
…ilation instead of qemu emulation
Motivation:
Current armhf Sonic build on amd64 host uses qemu emulation. Due to the nature of the emulation it takes a very long time, about 22-24 hours to complete the build. The change I did to improve the building time ports Sonic armhf build on amd64 host for Marvell platform for debian buster to use cross-compilation on arm64 host for armhf target. The overall Sonic armhf building time using cross-compilation is about 6 hours.
The Sonic configure and build for the armhf cross-compilation is as following:
Sonic module should check if $CROSS_BUILD_ENVIRON is 'y' to make sure that it is cross-compilation build.