Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Barefoot] enable bulk api`s in SAI #927

Merged

Conversation

KostiantynYarovyiBf
Copy link
Contributor

Why I did it:
Bulk was disable
How I did it:
enable bulk api`s in SAI for Barefoot
How to verify it:
Run sanity regression tests

kcudnik
kcudnik previously approved these changes Sep 9, 2021
@KostiantynYarovyiBf KostiantynYarovyiBf force-pushed the kyarovyi/barefoot_bulk_syncd branch 6 times, most recently from c4d5a41 to 426b7a0 Compare September 17, 2021 07:56
@kcudnik
Copy link
Collaborator

kcudnik commented Sep 17, 2021

entire PR is just adding empty line, is that it ?

@KostiantynYarovyiBf KostiantynYarovyiBf marked this pull request as draft September 17, 2021 08:46
@KostiantynYarovyiBf KostiantynYarovyiBf force-pushed the kyarovyi/barefoot_bulk_syncd branch from 426b7a0 to b90d05a Compare September 17, 2021 11:41
@KostiantynYarovyiBf KostiantynYarovyiBf marked this pull request as ready for review September 17, 2021 11:42
@KostiantynYarovyiBf
Copy link
Contributor Author

entire PR is just adding empty line, is that it ?

this was a test. I decided to check if my changes affect the fail CI tests. Now I returning my changes

kcudnik
kcudnik previously approved these changes Sep 19, 2021
syncd/VendorSai.cpp Outdated Show resolved Hide resolved
syncd/VendorSai.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@kcudnik kcudnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address comments

@KostiantynYarovyiBf KostiantynYarovyiBf force-pushed the kyarovyi/barefoot_bulk_syncd branch from 217c7d1 to ceb6cbb Compare September 21, 2021 13:28
kcudnik
kcudnik previously approved these changes Sep 21, 2021
    Bulk was disable
How I did it:
    Enable bulk on Barefoot
How to verify it:
    Run sanity regression tests
@kcudnik kcudnik merged commit 6df04d8 into sonic-net:master Sep 23, 2021
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants