-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Barefoot] enable bulk api`s in SAI #927
Merged
kcudnik
merged 1 commit into
sonic-net:master
from
KostiantynYarovyiBf:kyarovyi/barefoot_bulk_syncd
Sep 23, 2021
Merged
[Barefoot] enable bulk api`s in SAI #927
kcudnik
merged 1 commit into
sonic-net:master
from
KostiantynYarovyiBf:kyarovyi/barefoot_bulk_syncd
Sep 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcudnik
previously approved these changes
Sep 9, 2021
KostiantynYarovyiBf
force-pushed
the
kyarovyi/barefoot_bulk_syncd
branch
6 times, most recently
from
September 17, 2021 07:56
c4d5a41
to
426b7a0
Compare
entire PR is just adding empty line, is that it ? |
KostiantynYarovyiBf
force-pushed
the
kyarovyi/barefoot_bulk_syncd
branch
from
September 17, 2021 11:41
426b7a0
to
b90d05a
Compare
this was a test. I decided to check if my changes affect the fail CI tests. Now I returning my changes |
kcudnik
previously approved these changes
Sep 19, 2021
KostiantynYarovyiBf
force-pushed
the
kyarovyi/barefoot_bulk_syncd
branch
from
September 20, 2021 06:49
b90d05a
to
b6901f0
Compare
kcudnik
reviewed
Sep 21, 2021
kcudnik
reviewed
Sep 21, 2021
kcudnik
requested changes
Sep 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
address comments
KostiantynYarovyiBf
force-pushed
the
kyarovyi/barefoot_bulk_syncd
branch
from
September 21, 2021 13:28
217c7d1
to
ceb6cbb
Compare
kcudnik
previously approved these changes
Sep 21, 2021
KostiantynYarovyiBf
force-pushed
the
kyarovyi/barefoot_bulk_syncd
branch
from
September 22, 2021 09:06
ceb6cbb
to
d9a34b8
Compare
Bulk was disable How I did it: Enable bulk on Barefoot How to verify it: Run sanity regression tests
kcudnik
approved these changes
Sep 23, 2021
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it:
Bulk was disable
How I did it:
enable bulk api`s in SAI for Barefoot
How to verify it:
Run sanity regression tests