Add asicdump tool to view asic state #116
Conversation
| }; | ||
|
|
||
| CmdOptions g_cmdOptions; | ||
| std::map<sai_object_id_t, const TableMap*> g_oid_map; |
There was a problem hiding this comment.
std:: [](start = 0, length = 5)
'std::' can be removed.
There was a problem hiding this comment.
i use std:: every time in cpp
|
|
||
| size_t max = 0; | ||
|
|
||
| for (const auto&field: map) |
There was a problem hiding this comment.
auto &field
or
auto& field
|
|
||
| int main(int argc, char ** argv) | ||
| { | ||
| swss::Logger::getInstance().setMinPrio(swss::Logger::SWSS_DEBUG); |
There was a problem hiding this comment.
swss::Logger::getInstance().setMinPrio(swss::Logger::SWSS_DEBUG); [](start = 4, length = 65)
Can be removed?
There was a problem hiding this comment.
i want log enter to be logged in main to know when new process started, i will add leter on other notice enter
| @@ -1 +1 @@ | |||
| SUBDIRS = meta lib vslib syncd player | |||
| SUBDIRS = meta lib vslib syncd player asicdump | |||
There was a problem hiding this comment.
mellanox has a sdkdump to dump all sdk state, to differentiate with sdkdump, can we call it saidump? for the player, can we call it saiplayer?
There was a problem hiding this comment.
i'll change player to saiplayer
|
since this is strictly combined with redis maybe sairedisdump and sairedisplayer ? |
No description provided.