Convert meta to saimetadata library #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Oct 25, 2016
lguohan
reviewed
Oct 25, 2016
| @@ -1 +1 @@ | |||
| SUBDIRS = lib vslib syncd | |||
| SUBDIRS = meta lib vslib syncd player | |||
There was a problem hiding this comment.
which package will include this player binary? syncd.deb?
There was a problem hiding this comment.
there will be separate package saimetadata.deb
There was a problem hiding this comment.
player seems to be counterpart of syncd. Maybe better to be syncd? saimetadata seems to be metadata checking library that can be used by others?
There was a problem hiding this comment.
yes, metadata will be moved to SAI after making this work and converting it to C interface (this is not high priority right now), as for player, it works with syncd, i added it as separate project now, can change that later
jianyuewu
pushed a commit
to jianyuewu/sonic-sairedis
that referenced
this pull request
Feb 7, 2025
[core dump] remove number of parameter assumption from script coredump-compress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.