Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing PM and VDM related EEPROM reads #326

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

mihirpat1
Copy link
Contributor

Signed-off-by: Mihir Patel [email protected]

Description

This task will track missing EEPROM reads various PM and VDM fields.
Following fields are currently being planned to be added

  1. Post-FEC errored frames ratio
  2. EVM

Motivation and Context

This change set adds EEPROM reads for few PM/VDM related fields so that the DB can be updated accordingly.

How Has This Been Tested?

Please refer to the below attachment for the testing details.
pm_vdm_test.txt

Additional Information (Optional)

@mihirpat1 mihirpat1 marked this pull request as ready for review November 21, 2022 20:33
@mihirpat1 mihirpat1 requested a review from prgeor November 21, 2022 20:35
@prgeor prgeor added the CMIS label Nov 21, 2022
@prgeor prgeor merged commit f5ba0d0 into sonic-net:master Nov 21, 2022
yxieca pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: Mihir Patel <[email protected]>

Signed-off-by: Mihir Patel <[email protected]>
StormLiangMS pushed a commit to StormLiangMS/sonic-platform-common that referenced this pull request Dec 11, 2022
StormLiangMS pushed a commit that referenced this pull request Dec 11, 2022
Signed-off-by: Mihir Patel <[email protected]>

Signed-off-by: Mihir Patel <[email protected]>
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
* Xcvrd should restart if any child thread crashes

Signed-off-by: Mihir Patel <[email protected]>

* Resolved test_SfpStateUpdateTask_task_run_stop test failure

* Added comment for raise_exception

Signed-off-by: Mihir Patel <[email protected]>

* Added check for avoiding cmis_manager.start() if CMIS thread is supposed to be skipped. Also, moidified join function to handle accordingly. Added logs for showing names of threads spawned

Signed-off-by: Mihir Patel <[email protected]>

Signed-off-by: Mihir Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants