Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macsec profiles to accept type 7 encoded keys #9873

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

judyjoseph
Copy link
Contributor

What is the motivation for this PR?

PR : #9812 in branch 202205

How did you do it?

All details in #9812

How did you verify/test it?

All details in #9812

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yxieca pushed a commit that referenced this pull request Sep 7, 2023
What is the motivation for this PR?
There is a deadlock to merge this sonic-swss submodule PR: sonic-net/sonic-buildimage#16455 as it has a prerequisite to merge this PR : #9873 before that

Both PR's are dependent on each other and hence both PR merge is blocked.

How did you do it?
To fix and come out of the deadlock, solution is to skip macsec tests in t0-sonic testbed and let the sonic-mgmt PR #9873 merge . We will introduce the macsec again and let is pass for the sonic-swss submodule update PR
@yejianquan yejianquan merged commit d2875c3 into sonic-net:202205 Sep 8, 2023
@judyjoseph judyjoseph deleted the macsec_202205_type7 branch September 21, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants