Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PCBB] [202012] Add testcases to verify separated DSCP_TO_TC_MAP on leaf router #6817

Merged

Conversation

bingwang-ms
Copy link
Collaborator

Description of PR

Summary:
This PR is to backport PR #6393 into 202012 branch.
This PR is to add two new test cases testQosSaiSeparatedDscpQueueMapping and testQosSaiSeparatedDscpToPgMapping to verify separated DSCP_TO_TC_MAP for uplink and downlink on T1.

Code change in sonic-buildimage sonic-net/sonic-buildimage#11569

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

This PR is to add two new test cases testQosSaiSeparatedDscpQueueMapping and testQosSaiSeparatedDscpToPgMapping to verify separated DSCP_TO_TC_MAP for uplink and downlink on T1.

How did you do it?

  1. Swap syncd docker to syncd-rpc
  2. Generate traffic with various DSCP value, and send the packet to DUT from uplink ports or downlink ports
  3. Check the increment in each PG and Queue with SAI rpc call.

How did you verify/test it?

Verified on a TH2 device


collected 2 items                                                                                                                                                                                     

qos/test_qos_sai.py::TestQosSai::testQosSaiSeparatedDscpQueueMapping[str-7260cx3-acs-7-None-downstream] PASSED                                                                                  [ 50%]
qos/test_qos_sai.py::TestQosSai::testQosSaiSeparatedDscpQueueMapping[str-7260cx3-acs-7-None-upstream]  PASSED                                                                                    [100%]


collected 2 items                                                                                                                                                                                     

qos/test_qos_sai.py::TestQosSai::testQosSaiSeparatedDscpToPgMapping[str-7260cx3-acs-7-None-downstream] PASSED                                                                                   [ 50%]
qos/test_qos_sai.py::TestQosSai::testQosSaiSeparatedDscpToPgMapping[str-7260cx3-acs-7-None-upstream] PASSED                                                                                     [100%]

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

T1 specific test cases.

Documentation

@lgtm-com
Copy link

lgtm-com bot commented Nov 14, 2022

This pull request introduces 5 alerts when merging 0758aa1 into f24a9fa - view on LGTM.com

new alerts:

  • 3 for Except block handles 'BaseException'
  • 2 for Unused import

@wangxin wangxin merged commit caf463e into sonic-net:202012 Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants