Add condition_logical_operator or for test_passw_hardening.py #6482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhaohui Sun <[email protected]>
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 17, 2022
…net#6482) What is the motivation for this PR? passw_hardening/test_passw_hardening.py should be ran on master image and with issue sonic-net#6428 fixed. Currently, issue sonic-net#6428 is not fixed, the defulat logical operator is AND, so for master image, the final result is False, the case is not skipped. How did you do it? Change condition_logical_operator to OR, if the issue is fixed, it will run on master image, otherwise it will be skipped for all images. Signed-off-by: Zhaohui Sun <[email protected]>
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
…net#6482) What is the motivation for this PR? passw_hardening/test_passw_hardening.py should be ran on master image and with issue sonic-net#6428 fixed. Currently, issue sonic-net#6428 is not fixed, the defulat logical operator is AND, so for master image, the final result is False, the case is not skipped. How did you do it? Change condition_logical_operator to OR, if the issue is fixed, it will run on master image, otherwise it will be skipped for all images. Signed-off-by: Zhaohui Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhaohui Sun [email protected]
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
passw_hardening/test_passw_hardening.pyshould be ran on master image and with issue #6428 fixed.Currently, issue #6428 is not fixed, the defulat logical operator is AND, so for master image, the final result is False, the case is not skipped.
How did you do it?
Change condition_logical_operator to OR, if the issue is fixed, it will run on master image, otherwise it will be skipped for all images.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation