Fix for dualtor_io/test_tor_bgp_failure.py on dt/dt120 #17370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #445
Type of change
Back port request
Approach
What is the motivation for this PR?
Improving regex match in 17173
Some examples of the syslog entries encountered when running dualtor_io/test_tor_bgp_failure.py -
ERR bgp#mgmtd[34]: [X3G8F-PM93W] BE-adapter: mgmt_msg_read: got EOF/disconnect
ERR bgp#mgmtd[38]: [X3G8F-PM93W] BE-adapter: mgmt_msg_read: got EOF/disconnect
ERR bgp#mgmtd[32]: [X3G8F-PM93W] BE-adapter: mgmt_msg_read: got EOF/disconnect
How did you do it?
Changed regex to match any decimal digits instead of just 33
How did you verify/test it?
Ran dualtor_io/test_tor_bgp_failure.py on DCS-7260CX3 and DCS-7050CX3
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation