[action] [PR:16683] Fix l2/test_l2_configure.py for dualtor. #17352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the motivation for this PR?
l2/test_l2_configure.py fails on dualtor and leaves the testbed in bad state.
E tests.common.errors.RunAnsibleModuleFail: run module minigraph_facts failed, Ansible Results =>
E failed = True
E msg = Error reading file '/etc/sonic/minigraph.xml': failed to load external entity "/etc/sonic/minigraph.xml"
E Traceback (most recent call last):
E File "/tmp/ansible_minigraph_facts_payload_shhocew6/ansible_minigraph_facts_payload.zip/ansible/modules/minigraph_facts.py", line 924, in main
E File "/tmp/ansible_minigraph_facts_payload_shhocew6/ansible_minigraph_facts_payload.zip/ansible/modules/minigraph_facts.py", line 653, in parse_xml
E File "/tmp/ansible_minigraph_facts_payload_shhocew6/ansible_minigraph_facts_payload.zip/ansible/modules/minigraph_facts.py", line 608, in reconcile_mini_graph_locations
E File "src/lxml/etree.pyx", line 3538, in lxml.etree.parse
E File "src/lxml/parser.pxi", line 1876, in lxml.etree._parseDocument
E File "src/lxml/parser.pxi", line 1902, in lxml.etree._parseDocumentFromURL
E File "src/lxml/parser.pxi", line 1805, in lxml.etree._parseDocFromFile
E File "src/lxml/parser.pxi", line 1177, in lxml.etree._BaseParser._parseDocFromFile
E File "src/lxml/parser.pxi", line 615, in lxml.etree._ParserContext._handleParseResultDoc
E File "src/lxml/parser.pxi", line 725, in lxml.etree._handleParseResult
E File "src/lxml/parser.pxi", line 652, in lxml.etree._raiseParseError
E OSError: Error reading file '/etc/sonic/minigraph.xml': failed to load external entity "/etc/sonic/minigraph.xml"
E
E invocation = {'module_args': {'host': 'gd437', 'filename': None, 'namespace': None}}
E _ansible_no_log = None
E changed = False
E stdout =
E stderr =
The test removes minigraph but since the test doesn't take into account dualtor so it fails. The restoration of minigraph.xml is a part of test body (rather than in fixture teardown), hence the minigraph is never restored and the testbed goes into a bad state leading to every subsequent test failing.
How did you do it?
The proposed fix is to take into account the dualtor behaviour and take mux out of the list of critical services while the test loads the DUT with bare minimum L2 config. Also the part to restore minigraph.xml has been moved to a fixture teardown so that it's fate is not tied to the the test passing.
How did you verify/test it?
Tested on Arista-7260CX3 platform with dualtor-120 and dualtor-aa-56 topology.
|
/azp run |
11 tasks
|
Original PR: #16683 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #394
Type of change
Back port request
Approach
What is the motivation for this PR?
l2/test_l2_configure.py fails on dualtor and leaves the testbed in bad state.
The test removes minigraph but since the test doesn't take into account dualtor so it fails. The restoration of minigraph.xml is a part of test body (rather than in fixture teardown), hence the minigraph is never restored and the testbed goes into a bad state leading to every subsequent test failing.
How did you do it?
The proposed fix is to take into account the dualtor behaviour and take mux out of the list of critical services while the test loads the DUT with bare minimum L2 config. Also the part to restore
minigraph.xmlhas been moved to a fixture teardown so that it's fate is not tied to the the test passing.How did you verify/test it?
Tested on Arista-7260CX3 platform with dualtor-120 and dualtor-aa-56 topology.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation