Add verification for interface counters on sanity check #1165
Conversation
Signed-off-by: Yuriy Volynets <[email protected]>
Signed-off-by: Yuriy Volynets <[email protected]>
|
@wangxin can you please review as well? |
| @@ -56,3 +56,6 @@ | |||
| - name: Verify VLAN interfaces are up correctly | |||
| assert: { that: "'{{ ansible_interface_facts[item]['active'] }}' == 'True'" } | |||
| with_items: "{{ minigraph_vlans.keys() }}" | |||
|
|
|||
| - name: Verify interfaces counters | |||
| include: interface_counters.yml | |||
There was a problem hiding this comment.
I wonder if we should this new test as pytest?
There was a problem hiding this comment.
"I wonder if we should this new test as pytest?" - in my opinion we should add this in pytest and other features which are executed during run ansible test cases.
Here in ansible approach, this specific verification is a part of sanity check which performs before and after each test case. Currently in pytest approach there is no such functionality.
I think first we should understand and agree:
what steps should be done before and after each test case.
If current ansible logic is enough and its not redundant then it can be ported to the pytest.
Then this verification and more others will be executed per test case.
There was a problem hiding this comment.
@lguohan is this closed and we can merge?
There was a problem hiding this comment.
@lguohan I agree with @yvolynets-mlnx here, I think we should add this check and port it back to pytest with the rest of the interface tests.
|
@lguohan Sorry, this was not meant to be merged until sonic-net/sonic-buildimage#2738 is resolved. |
Summary: temporally disable interface counters check to avoid test case failures until: Issue sonic-net/sonic-buildimage#2738 will be fixed PR #1165 will be merged Signed-off-by: Yuriy Volynets <[email protected]>
|
looks like this pr cannot be merged automatically, can you generate a pr to manually revert it? |
|
We have created a PR to temporarily disable interface counter sanity check by commenting out a few lines in ansible/roles/test/tasks/interface.yml: #1467 |
Description of PR
Do not merge until sonic-net/sonic-buildimage#2738 will be fixed.
Summary:
Extended pre and post test sanity check with:
Type of change
Approach
How did you do it?
Developed new common purpose ansible library - counter_facts.py. Its purpose is to gather interface counters. This library can be extendent to gather any kind of counters.
Developed "interface_counters.yml" script which calls "counter_facts" module and perform verification that "N/A" are absent.
Updated "interface.yml" to call "interface_counters.yml".
How did you verify/test it?
Tested on the local setup.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation