[Arista] skip testing sfp interfaces on Arista-7050QX-32S-S4Q31 #10821
Conversation
This is to skip testing SFP interfaces on Arista-7050QX-32S-S4Q31. They were skipped by RJ45 setting on the hwsku.json. But for some conflicts on port index setting of different breakout modes, hwsku.json is deleted to use port_config.ini for the correct port index.
| @@ -76,6 +76,12 @@ def xcvr_skip_list(duthosts): | |||
| logging.debug( | |||
| "hwsku.json absent or port_type for interfaces not included for hwsku {}".format(hwsku)) | |||
|
|
|||
| # No hwsku.json for Arista-7050-QX-32S/Arista-7050QX-32S-S4Q31 | |||
There was a problem hiding this comment.
@byu343 Why there is a change in behavior?
There was a problem hiding this comment.
We decided to remove hwsku.json (in the change sonic-net/sonic-buildimage#17253) because 1) the correct port index should be 1,2,3,4 for the SFP ports under this hwsku Arista-7050-QX-32S/Arista-7050QX-32S-S4Q31; 2) but same logical ports with a different breakout mode under another hwsku have to use port index 5,5,5,5, which is in https://github.com/sonic-net/sonic-buildimage/blob/master/device/arista/x86_64-arista_7050_qx32s/platform.json#L215; 3) removing hwsku.json will fall back to use port_config.ini, where we can set the port index as 1,2,3,4 while not affecting other hwskus.
The xcvr_skip_list here was to skip SFP based on the RJ45 setting in hwsku.json, but since the hwsku.json of Arista-7050-QX-32S/Arista-7050QX-32S-S4Q31 has to be removed, we decided to add the skip for the hwskus in the test code here.
|
@wangxin please merge |
|
@StormLiangMS , @yxieca - Can you please help in merging to 202305 and 202205 branch. |
@StormLiangMS, @yxieca - This PR is merged now. It will be great if you can help with the cherry-pick process. |
…c-net#10821) This is to skip testing SFP interfaces on Arista-7050QX-32S-S4Q31. They were skipped by RJ45 setting on the hwsku.json. But for some conflicts on port index setting of different breakout modes, hwsku.json is deleted to use port_config.ini for the correct port index.
|
Cherry-pick PR to 202305: #11105 |
This is to skip testing SFP interfaces on Arista-7050QX-32S-S4Q31. They were skipped by RJ45 setting on the hwsku.json. But for some conflicts on port index setting of different breakout modes, hwsku.json is deleted to use port_config.ini for the correct port index.
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
…c-net#10821) This is to skip testing SFP interfaces on Arista-7050QX-32S-S4Q31. They were skipped by RJ45 setting on the hwsku.json. But for some conflicts on port index setting of different breakout modes, hwsku.json is deleted to use port_config.ini for the correct port index.
|
Cherry-pick PR to 202205: #11542 |
This is to skip testing SFP interfaces on Arista-7050QX-32S-S4Q31. They were skipped by RJ45 setting on the hwsku.json. But for some conflicts on port index setting of different breakout modes, hwsku.json is deleted to use port_config.ini for the correct port index.
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
Description of PR
Summary:
Fixes # (issue)
This is to skip testing SFP interfaces on Arista-7050QX-32S-S4Q31. They were skipped by RJ45 setting (https://github.com/sonic-net/sonic-mgmt/blob/master/tests/platform_tests/conftest.py#L70) by the hwsku.json (https://github.com/sonic-net/sonic-buildimage/pull/15251/files#diff-d66b493f5f334902184958f8afcbc387645e4033fe147bf1c0a1ac103d643d0bL5). But for some conflicts on port index setting of different breakout modes, hwsku.json would be deleted to use port_config.ini for the correct port index (sonic-net/sonic-buildimage#17253). The change here is to skip SFP interfaces of Arista-7050QX-32S-S4Q31 in the test code.
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation