[hostcfgd] differentiate between UnitFileState and UnitFilePreset #8169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be that service is not enabled but UnitFilePreset=enabled (case
for Application Extension):
```
Loaded: loaded (/lib/systemd/system/cpu-report.service; disabled; vendor preset: enabled)
```
This makes existing logic skip enabling the service.
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
|
@yxieca could you please help to review? note that this is a degradation noticed in both master and 202012 thus the urgency. |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
approved these changes
Jul 15, 2021
yxieca
approved these changes
Jul 19, 2021
|
This PR could not be cleanly cherry-pick to 202012. Please submit another PR. |
stepanblyschak
added a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Jul 20, 2021
…nic-net#8169) It can be that service is not enabled but UnitFilePreset=enabled (case for Application Extension): ``` Loaded: loaded (/lib/systemd/system/cpu-report.service; disabled; vendor preset: enabled) ``` This makes existing logic skip enabling the service. Signed-off-by: Stepan Blyschak <[email protected]>
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Jul 21, 2021
) (#8228) It can be that service is not enabled but UnitFilePreset=enabled (case for Application Extension): ``` Loaded: loaded (/lib/systemd/system/cpu-report.service; disabled; vendor preset: enabled) ``` This makes existing logic skip enabling the service. Signed-off-by: Stepan Blyschak <[email protected]>
judyjoseph
pushed a commit
that referenced
this pull request
Aug 7, 2021
) It can be that service is not enabled but UnitFilePreset=enabled (case for Application Extension): ``` Loaded: loaded (/lib/systemd/system/cpu-report.service; disabled; vendor preset: enabled) ``` This makes existing logic skip enabling the service. Signed-off-by: Stepan Blyschak <[email protected]>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…nic-net#8169) It can be that service is not enabled but UnitFilePreset=enabled (case for Application Extension): ``` Loaded: loaded (/lib/systemd/system/cpu-report.service; disabled; vendor preset: enabled) ``` This makes existing logic skip enabling the service. Signed-off-by: Stepan Blyschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be that service is not enabled but UnitFilePreset=enabled (case
for Application Extension):
This makes existing logic skip enabling the service.
Signed-off-by: Stepan Blyschak [email protected]
Why I did it
To fix an issue when a 3rd party package cannot be started by hostcfgd.
How I did it
Check explicitely for UnitFileState.
How to verify it
Ran UT & ran it on the switch.
Installed 3rd party package and enabled it in config db, verified feature can start.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)