Revert "[Telemetry docker] add memory and memory swap limits" #7582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0c59278.
qiluo-msft
approved these changes
May 11, 2021
|
@pra-moh: Can you please add details to the PR description as to why this is necessary for posterity? |
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…et#7062)" (sonic-net#7582) This reverts commit 0c59278.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7062
PR #7062 - Dockers memory threshold assignment make device reboot instead of docker restart when memory is reached. This happens because OOM signal goes to kernel and currently kernel makes device reboot based on this change- #2988. If kernel settings are changed to panic_on_oom = 0 and
oom_kill_allocating_task = 1 then it kills docker which gave OOM error but downside is it can kill any other process randomly. Hence we do not want memory threshold setting per docker in #7062