-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker-base-buster][docker-config-engine-buster] No longer install Python 2 #6162
Changes from 1 commit
42c792b
ebf10a4
cfb9452
b3fe099
67ffd8a
ebf67a0
b1f0b1d
6bad421
1c88eaf
3207bdd
2728f3f
a156956
7859787
82b64b6
5b84690
b0f53d0
6e8679b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -370,7 +370,7 @@ RUN export VERSION=1.14.2 \ | |
&& rm go$VERSION.linux-*.tar.gz | ||
|
||
RUN pip3 install --upgrade pip | ||
RUN pip2 install --upgrade pip<21 | ||
RUN pip2 install --upgrade 'pip<21' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure why need this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In January, pip version 21 will be released, which will drop support for Python 2. Therefore, we need to ensure we install a version < 21 for Python 2 purposes. |
||
RUN apt-get purge -y python-pip python3-pip | ||
|
||
# For building Python packages | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -339,7 +339,7 @@ RUN export VERSION=1.14.2 \ | |
&& rm go$VERSION.linux-*.tar.gz | ||
|
||
RUN pip3 install --upgrade pip | ||
RUN pip2 install --upgrade pip<21 | ||
RUN pip2 install --upgrade 'pip<21' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure why need this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In January, pip version 21 will be released, which will drop support for Python 2. Therefore, we need to ensure we install a version < 21 for Python 2 purposes. |
||
RUN apt-get purge -y python-pip python3-pip | ||
|
||
# For p4 build | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why to touch it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In January, pip version 21 will be released, which will drop support for Python 2. Therefore, we need to ensure we install a version < 21 for Python 2 purposes.