Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hostimage] No need to mark packages as auto since all debootstrap installed packages are fundamental and will not be removed #6159

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

qiluo-msft
Copy link
Collaborator

@qiluo-msft qiluo-msft commented Dec 8, 2020

- Why I did it
Originally this line is used to mark all previously installed packages (deboostrap installed) as auto, so later if no other packages depend on anyone of them, it will be auto removed. Seems we gained little from this line, so let's remove it.

- How I did it

- How to verify it
Check the build log after sudo LANG=C chroot ./fsroot apt-get -y autoremove and the removed packages are unchanged.

The following packages will be REMOVED:
  binutils binutils-common binutils-x86-64-linux-gnu cpp cpp-8 gcc-8 libasan5
  libatomic1 libbinutils libc-dev-bin libc6-dev libcc1-0 libexpat1-dev
  libgcc-8-dev libgomp1 libisl19 libitm1 liblsan0 libmpc3 libmpfr6 libmpx2
  libquadmath0 libtsan0 libubsan1 linux-libc-dev
0 upgraded, 0 newly installed, 25 to remove and 5 not upgraded.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

packages are fundamental and will not be removed
@qiluo-msft
Copy link
Collaborator Author

Retest vsimage please

@lguohan lguohan merged commit b0fdeff into sonic-net:master Dec 10, 2020
@qiluo-msft qiluo-msft deleted the qiluo/noauto branch December 10, 2020 19:04
qiluo-msft added a commit to qiluo-msft/sonic-buildimage that referenced this pull request Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants