Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of platform-specific interfaces #2631

Merged
merged 1 commit into from
Mar 9, 2019
Merged

Allow configuration of platform-specific interfaces #2631

merged 1 commit into from
Mar 9, 2019

Conversation

pyadvichuk
Copy link

@pyadvichuk pyadvichuk commented Mar 1, 2019

- Why it is required
since SONiC master switches ifupdown package to the new implementation (ifupdown2), it is required to change the configuration of a platform-specific interface for wedge100bf_32x and wedge100bf_65x platforms (bc of ifupdown2 doesn't support auto mode for inet6 protocol).

Also, need to make some refactoring and remove if platform == smth then.. from the system level scripts.

- What I did

  • removed customization of /usr/bin/interfaces-config.sh
  • explicitly created directory /etc/network/interfaces.d
  • added "source" to the /etc/network/interfaces generation template (to include platform-specific interfaces processing)
  • added platform-specific interfaces config itself (for wedge100bf_32x and wedge100bf_65x)
  • fixed testcase in sonic-config-engine

- How to verify it

  • build image for wedge100bf_32x
  • perform sudo config reload -y on new installation
  • check the correct configuration of usb0 interface

- Description for the changelog

  • Allow configuration of platform-specific interfaces

@akokhan, @mkbalani: please review this first

@lguohan: please review and merge this

@msftclas
Copy link

msftclas commented Mar 1, 2019

CLA assistant check
All CLA requirements met.

@mkbalani
Copy link
Contributor

mkbalani commented Mar 1, 2019

@pyadvichuk without auto config in " iface usb0 inet6 auto" is the BMC interface configured correctly. What is the default when auto/dhcp/static is not used. We need the BMC to come with some IPv6 address config

@lguohan
Copy link
Collaborator

lguohan commented Mar 2, 2019

@pyadvichuk , please sign cla.

@pyadvichuk
Copy link
Author

@pyadvichuk without auto config in " iface usb0 inet6 auto" is the BMC interface configured correctly. What is the default when auto/dhcp/static is not used. We need the BMC to come with some IPv6 address config

@mkbalani, by default static link level v6 address is assigned. I've checked REST over this interface by sensors command. Everything looks good.

@marian-pritsak marian-pritsak dismissed their stale review March 4, 2019 09:37

Changes not needed

@akokhan
Copy link
Contributor

akokhan commented Mar 6, 2019

@lguohan is there anything that blocks us from merging this? Thanks.

@lguohan lguohan merged commit 11c2e9e into sonic-net:master Mar 9, 2019
@pyadvichuk pyadvichuk deleted the bfn-bmc-intf-configuration branch June 19, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants