[docker-ptf] Add Tornado WSGI #21655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enables replacing Flask based http-api with Tornado app
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
|
/azp run |
|
Commenter does not have sufficient privileges for PR 21655 in repo sonic-net/sonic-buildimage |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Mar 5, 2025
miatttao
pushed a commit
to miatttao/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
Why I did it This PR adds tornado Tornado WSGI package to docker-ptf image. This will enable replacing the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner. Work item tracking Microsoft ADO (number only): 31250273 How I did it Added tornado package to the docker-ptf image. How to verify it Ran add, remove topology to check announce routes Ran route stress test to verify it is stable Which release branch to backport (provide reason below if selected) 201811 201911 202006 202012 202106 202111 202205 202211 202305 Tested branch (Please provide the tested image version) NA Description for the changelog [docker-ptf] Add Tornado WSGI This PR adds tornado Tornado WSGI package to docker-ptf image. This will enable replacing the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner.
prabhataravind
pushed a commit
to prabhataravind/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
Why I did it This PR adds tornado Tornado WSGI package to docker-ptf image. This will enable replacing the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner. Work item tracking Microsoft ADO (number only): 31250273 How I did it Added tornado package to the docker-ptf image. How to verify it Ran add, remove topology to check announce routes Ran route stress test to verify it is stable Which release branch to backport (provide reason below if selected) 201811 201911 202006 202012 202106 202111 202205 202211 202305 Tested branch (Please provide the tested image version) NA Description for the changelog [docker-ptf] Add Tornado WSGI This PR adds tornado Tornado WSGI package to docker-ptf image. This will enable replacing the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This PR adds
tornadoTornado WSGI package to docker-ptf image. This will enable replacing the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner.Work item tracking
How I did it
Added
tornadopackage to thedocker-ptfimage.How to verify it
Ran add, remove topology to check announce routes
Ran route stress test to verify it is stable
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
NA
Description for the changelog
[docker-ptf] Add Tornado WSGI
tornadoTornado WSGI package to docker-ptf image. This will enable replacing the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner.Link to config_db schema for YANG module changes
NA
A picture of a cute animal (not mandatory but encouraged)