[Bgpcfgd] Update bgpcfgd to handle SRV6_MY_SIDS table's key as an ipv6 prefix #21468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abdosi
reviewed
Jan 18, 2025
| @@ -71,10 +69,10 @@ def sids_set_handler(self, key, data): | |||
| log_err("Found a SRv6 SID config entry associated with unsupported action: {} | {}".format(key, data)) | |||
| return False | |||
|
|
|||
| sid = SID(locator_name, ip_addr, data) # the information in data will be parsed into SID's attributes | |||
| sid = SID(locator_name, ip_prefix, data) # the information in data will be parsed into SID's attributes | |||
There was a problem hiding this comment.
where are we doing validation for prefix_len >= block_len + node_len ?
There was a problem hiding this comment.
added in the new commit
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cscarpitta
approved these changes
Jan 20, 2025
ahsalam
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
LGTM. The SID is configured as a prefix in FRR.
The CLI to support this has been merged into FRR mainline (FRRouting/frr#16894). The CLI has been ported into SONiC mainline (#21380).
abdosi
previously approved these changes
Jan 21, 2025
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BYGX-wcr
force-pushed
the
srv6-bgpcfgd-followup
branch
from
cca4f81 to
b471d82
Compare
BYGX-wcr
force-pushed
the
srv6-bgpcfgd-followup
branch
from
b471d82 to
ffa4a1e
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To adapt bgpcfgd to the new schema of SRV6_MY_SIDS
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)