[smartswitch][YANG]Add yang model for DPU_PORT information #21439
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vvolam
requested review from
oleksandrivantsiv,
rameshraghupathy,
ganglyu and
prgeor
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| leaf state { | ||
| description "Admin state of DPU device"; | ||
| type enumeration { |
There was a problem hiding this comment.
Please use sonic-types
| @@ -74,6 +84,63 @@ module sonic-smart-switch { | |||
| /* end of container DPUS_LIST */ | |||
| } | |||
| /* end of container DPUS */ | |||
|
|
|||
| container DPU_PORT { | |||
There was a problem hiding this comment.
could you add some unit test for this table here:
https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/tests/yang_model_pytests/test_smart_switch.py
| type string; | ||
| } | ||
|
|
||
| leaf gnmi { |
There was a problem hiding this comment.
Can we use gnmi_port instead of gnmi?
|
|
||
| leaf vip_ipv4 { | ||
| description "VIP IPv4 address from minigraph"; | ||
| type inet:ipv4-prefix; |
There was a problem hiding this comment.
Why do you use ipv4-prefix for vip_ipv4 and ipv4-address for pa_ipv4?
There was a problem hiding this comment.
My bad, fixed it now. Thank you!
Also, write test cases for DPU_PORT
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| @pytest.mark.parametrize( | ||
| "port_name, error_message", [ | ||
| ("port0", None), |
There was a problem hiding this comment.
What does "port0" mean? We should use "port0" for DPU0?
There was a problem hiding this comment.
"port0" here is the interface name on the dpu.
| leaf PORT_NAME { | ||
| description "Name of the DPU port"; | ||
| type string { | ||
| pattern "[a-z]+[0-9]+"; |
There was a problem hiding this comment.
This should include uppercase and lowercase letters
There was a problem hiding this comment.
Modified to include uppercase letters too. Thank you!
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Add yang model for the DPU_PORT information below:
DPU_PORT|<PORT_NAME>:
state: up|down ; admin state of DPU device
vip_ipv4: ipv4 prefix ; from minigraph
vip_ipv6: ipv6 prefix ; from minigraph
pa_ipv4: ipv4 pa ip ; from minigraph
pa_ipv6: ipv6 pa ip ; from minigraph
vdpu_id: id of vdpu ; from minigraph
gnmi: gnmi server port ;
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)