-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buffer configs for TH5 C224 and C256 SKUs #21155
base: master
Are you sure you want to change the base?
Conversation
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
THRESHOLD_MODE: LOSSY | ||
TM_SCHEDULER_CONFIG: | ||
NUM_MC_Q: NUM_MC_Q_2 | ||
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The BCM file seems to be missing all the queue configurations, this might cause problems. even CPU queue is not here, not sure if this is expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
service pool is also missing, is this expected? (ideally, this can be done by buffer SAI APIs, but in the 256x200G HWSKU, it didn't really work well.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for pure lossy config using SDK defaults. Will need to check if explicit service pool configs are required.
platform/broadcom/sai.mk
Outdated
LIBSAIBCM_DNX_VERSION = 11.2.13.1-1 | ||
LIBSAIBCM_XGS_BRANCH_NAME = SAI_11.2.16.2 | ||
LIBSAIBCM_XGS_BRANCH_NAME = SAI_11_2_16_2_CS00012372635 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this be the final branch name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is a temporary branch. Once we get the final fix from BCM, this will be moved to main branch
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Pull request contains merge conflicts. |
"{{ port }}|9": { | ||
"scheduler": "scheduler.1" | ||
} | ||
{%- endmacro -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi Kumaresh, is the WRED config also in here?
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@Gfrom2016 for viz. |
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)