Revert "Move eventd enabled check from build time to runtime" #20947
+33
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
approved these changes
Nov 27, 2024
|
@bingwang-ms , could you please also revert it in 202405? |
|
The change is reverted from 202405 by PR #20946 |
|
Hi @bingwang-ms @zbud-msft , should we also fix the issue in 202411? |
rlhui
added
Chassis 🤖
rlhui
added
Request for 202405 Branch
and removed
Request for msft-202405 Branch
Cherry Pick Conflict_msft-202405
labels
rlhui
removed
Request for 202405 Branch
P0
|
@zbud-msft Can you also file a PR for 202411 to revert? |
Hi @zbud-msft , Do we have same PR for 202411 ? Or this can be cherry picked with no issues to 202411 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #20248 and fixes #20544